 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH]libxc: fix a Segmentation fault
| To: | Yang Hongyang <yanghy@xxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH]libxc: fix a Segmentation fault |
| From: | Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx> |
| Date: | Mon, 28 Jun 2010 16:54:40 +0100 |
| Cc: | "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Mon, 28 Jun 2010 08:55:24 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <4C284523.4000304@xxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Newsgroups: | chiark.mail.xen.devel |
| References: | <4C284523.4000304@xxxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
Yang Hongyang writes ("[Xen-devel] [PATCH]libxc: fix a Segmentation fault"):
> # xl list
> xc: error: Could not obtain handle on privileged command interface (2 = No
> such file or directory): Internal error
> Segmentation fault
>
> This is because xc free the logger which xl created.
Well spotted. You're right about the cause, but your fix is not
correct. The correct fix is that xc_interface_open's error path
should free error_handler_tofree rather than error_handler. So there
is no need to add another variable. I will apply that fix.
Thanks,
Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [PATCH] add xl ocaml bindings [and 1 more messages], Ian Jackson |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH 3 of 3] xencommons: Wait for xenstored to start before setting dom0 name, Ian Jackson |
| Previous by Thread: | [Xen-devel] [PATCH]libxc: fix a Segmentation fault, Yang Hongyang |
| Next by Thread: | Re: [Xen-devel] [PATCH]libxc: fix a Segmentation fault, Yang Hongyang |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
