WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 		  
Home Products Support Community News
 
   
 

xen-devel

[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [Xen-devel] [PATCH6/6] cpuidle: redefine cpumask_lock as rwlock_t

from [Jan Beulich] [Permanent Link][Original]
To: "Gang Wei" <gang.wei@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH6/6] cpuidle: redefine cpumask_lock as rwlock_t
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Thu, 17 Jun 2010 09:29:56 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Thu, 17 Jun 2010 01:30:55 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <F26D193E20BBDC42A43B611D1BDEDE710F70FB865F@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <F26D193E20BBDC42A43B611D1BDEDE710F70FB865F@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
>>> On 17.06.10 at 09:38, "Wei, Gang" <gang.wei@xxxxxxxxx> wrote:
> cpuidle: redefine cpumask_lock as rwlock_t
> 
> Multiple cpus clear hpet channel cpumask simultaneously is ok. So we can 
> change the cpumask_lock to rwlock_t.

Now this I think really needs a comment in the code: You use a read
lock on the writer side and a write lock on the reader side - quite the
opposite of normal behavior.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [Xen-devel] [PATCH4/6] cpuidle: remove hpet access in hpet_broadcast_exit, Jan Beulich
Next by Date:  RE: [Xen-devel] [PATCH1/6] cpuidle: fix wrapped ticks calculation for pm timer, Wei, Gang
Previous by Thread:  [Xen-devel] [PATCH6/6] cpuidle: redefine cpumask_lock as rwlock_t, Wei, Gang
Next by Thread:  RE: [Xen-devel] [PATCH6/6] cpuidle: redefine cpumask_lock as rwlock_t, Wei, Gang
Indexes:  [Date] [Thread] [Top] [All Lists]
 
   

Copyright , Citrix Systems Inc. All rights reserved. Legal and Privacy