WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [PATCH6/6] cpuidle: redefine cpumask_lock as rwlock_t

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: RE: [Xen-devel] [PATCH6/6] cpuidle: redefine cpumask_lock as rwlock_t
From: "Wei, Gang" <gang.wei@xxxxxxxxx>
Date: Thu, 17 Jun 2010 16:54:15 +0800
Accept-language: zh-CN, en-US
Acceptlanguage: zh-CN, en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, "Wei, Gang" <gang.wei@xxxxxxxxx>
Delivery-date: Thu, 17 Jun 2010 01:55:37 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4C19F9240200007800006E15@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <F26D193E20BBDC42A43B611D1BDEDE710F70FB865F@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4C19F9240200007800006E15@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcsN90ZIKCUIQLylTiq8rCN9PXZRwwAA0j5g
Thread-topic: [Xen-devel] [PATCH6/6] cpuidle: redefine cpumask_lock as rwlock_t
On Thursday, 2010-6-17 4:30 PM, Jan Beulich wrote:
>>>> On 17.06.10 at 09:38, "Wei, Gang" <gang.wei@xxxxxxxxx> wrote:
>> cpuidle: redefine cpumask_lock as rwlock_t
>> 
>> Multiple cpus clear hpet channel cpumask simultaneously is ok. So we
>> can change the cpumask_lock to rwlock_t.
> 
> Now this I think really needs a comment in the code: You use a read
> lock on the writer side and a write lock on the reader side - quite
> the opposite of normal behavior.

Good suggestion, I will add it.

Jimmy
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>