WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 		  
Home Products Support Community News
 
   
 

xen-devel

[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [Xen-devel] [PATCH4/6] cpuidle: remove hpet access in hpet_broadcast

from [Jan Beulich] [Permanent Link][Original]
To: "Gang Wei" <gang.wei@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH4/6] cpuidle: remove hpet access in hpet_broadcast_exit
From: "Jan Beulich" <JBeulich@xxxxxxxxxx>
Date: Thu, 17 Jun 2010 09:26:07 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Thu, 17 Jun 2010 01:27:06 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <F26D193E20BBDC42A43B611D1BDEDE710F70FB865C@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <F26D193E20BBDC42A43B611D1BDEDE710F70FB865C@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx 
>>> On 17.06.10 at 09:38, "Wei, Gang" <gang.wei@xxxxxxxxx> wrote:
> BTW, move the cpumask set out of critial section in hpet_broadcast_enter to 
> shorten it.

Could you explain why you can move it out of the locked section for
_enter(), but can't for _exit() - this isn't obvious to me (and would
perhaps deserve a comment in the sources).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: [Xen-devel] IOMMU and AMD 890fx, Jens Krehbiel-Gräther
Next by Date:  Re: [Xen-devel] [PATCH6/6] cpuidle: redefine cpumask_lock as rwlock_t, Jan Beulich
Previous by Thread:  [Xen-devel] [PATCH4/6] cpuidle: remove hpet access in hpet_broadcast_exit, Wei, Gang
Next by Thread:  RE: [Xen-devel] [PATCH4/6] cpuidle: remove hpet access in hpet_broadcast_exit, Wei, Gang
Indexes:  [Date] [Thread] [Top] [All Lists]
 
   

Copyright , Citrix Systems Inc. All rights reserved. Legal and Privacy