This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 0/2] xl: Add subcommand mem-max and fix mem-set

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 0/2] xl: Add subcommand mem-max and fix mem-set
From: Yu Zhiguo <yuzg@xxxxxxxxxxxxxx>
Date: Wed, 12 May 2010 14:41:05 +0800
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Tue, 11 May 2010 23:41:42 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4BEA4A13.3000801@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4BE3DFBE.2010901@xxxxxxxxxxxxxx> <19428.20752.717993.453216@xxxxxxxxxxxxxxxxxxxxxxxx> <4BE67620.7010803@xxxxxxxxxxxxxx> <4BEA4A13.3000801@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 3.0a1 (Windows/2008050715)
Yu Zhiguo wrote:
> Yu Zhiguo wrote:
>> I'm trying to add subcommand 'mem-max', I think xc_domain_setmaxmem should
>> be used in it but not here.
>> I'll move this code to 'mem-max', and in 'mem-set', a check should be added
>> because setting memory larger than max memory is invalid.
>> 1. Add 'mem-max'
>>   Add libxl_domain_setmaxmem, it calls xc_domain_setmaxmem.
>>   /local/domain/$domid/memory/static-max should be updated when set max 
>> memory,
>> it is missing now.
>> 2. fix 'mem-set'
>>   Delete xc_domain_setmaxmem.
>>   Get max memory from /local/domain/$domid/memory/static-max, and then do 
>> value check.
>> It seems that we cannot get max memory use libxc routines.
> I fixed it, please check.
> [PATCH 1/2] xl: Add command 'xl mem-max'
> [PATCH 2/2] xl: Add check for command 'xl mem-set'

It seems than /local/domain/$domid/memory/target cannot be created when use 'xl 
only /local/domain/0/memory/static-max is existent.
Isn't it a bug? I'll check the code.

I think it should be created like static-max.
* memory/target can be created when use 'xm create'

> Regards
> Yu Zhiguo
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

Yu Zhiguo
Yu Zhiguo
Development Dept.I
Nanjing Fujitsu Nanda Software Tech. Co., Ltd.(FNST)
8/F., Civil Defense Building, No.189 Guangzhou Road,
Nanjing, 210029, China
TEL: +86+25-86630566-853
COINS: 79955-853
FAX: +86+25-83317685
MAIL: yuzg@xxxxxxxxxxxxxx
This communication is for use by the intended recipient(s) only and may contain 
information that is privileged, confidential and exempt from disclosure under 
applicable law. If you are not an intended recipient of this communication, you 
are hereby notified that any dissemination, distribution or copying hereof is 
strictly prohibited.  If you have received this communication in error, please 
notify me by reply e-mail, permanently delete this communication from your 
system, and destroy any hard copies you may have printed.

Xen-devel mailing list