This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH 0/2] xl: Add subcommand mem-max and fix mem-set

To: Yu Zhiguo <yuzg@xxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH 0/2] xl: Add subcommand mem-max and fix mem-set
From: Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
Date: Wed, 12 May 2010 12:33:41 +0100
Cc: Jonathan Knowles <Jonathan.Knowles@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>, Stefano Stabellini <Stefano.Stabellini@xxxxxxxxxxxxx>
Delivery-date: Wed, 12 May 2010 04:31:52 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4BEA4D81.40908@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4BE3DFBE.2010901@xxxxxxxxxxxxxx> <19428.20752.717993.453216@xxxxxxxxxxxxxxxxxxxxxxxx> <4BE67620.7010803@xxxxxxxxxxxxxx> <4BEA4A13.3000801@xxxxxxxxxxxxxx> <4BEA4D81.40908@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Alpine 2.00 (DEB 1167 2008-08-23)
On Wed, 12 May 2010, Yu Zhiguo wrote:
> Yu Zhiguo wrote:
> > Yu Zhiguo wrote:
> >> I'm trying to add subcommand 'mem-max', I think xc_domain_setmaxmem should
> >> be used in it but not here.
> >>
> >> I'll move this code to 'mem-max', and in 'mem-set', a check should be added
> >> because setting memory larger than max memory is invalid.
> >>
> >> 1. Add 'mem-max'
> >>   Add libxl_domain_setmaxmem, it calls xc_domain_setmaxmem.
> >>   /local/domain/$domid/memory/static-max should be updated when set max 
> >> memory,
> >> it is missing now.
> >>
> >> 2. fix 'mem-set'
> >>   Delete xc_domain_setmaxmem.
> >>   Get max memory from /local/domain/$domid/memory/static-max, and then do 
> >> value check.
> >> It seems that we cannot get max memory use libxc routines.
> >>
> > 
> > I fixed it, please check.
> > 
> > [PATCH 1/2] xl: Add command 'xl mem-max'
> > [PATCH 2/2] xl: Add check for command 'xl mem-set'
> > 
> It seems than /local/domain/$domid/memory/target cannot be created when use 
> 'xl create',
> only /local/domain/0/memory/static-max is existent.
> Isn't it a bug? I'll check the code.
> I think it should be created like static-max.
> * memory/target can be created when use 'xm create'

Actually sorry if I didn't reply in time before you sent your patches,
but I asked the xapi memory management expert (CC'ed) an
opinion on the memset/memmax commands, I have the impression
that he has something interesting to say about them.

Keir, could you please wait before applying these patches?

Xen-devel mailing list