This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Shall we clear the cpumap in XEN_DOMCTL_setvcpuaffinity

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: [Xen-devel] Shall we clear the cpumap in XEN_DOMCTL_setvcpuaffinity
From: "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>
Date: Wed, 12 May 2010 15:22:13 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 12 May 2010 00:23:40 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acrxo9fMxtcQKWhdSH+8fA5mN2iicw==
Thread-topic: Shall we clear the cpumap in XEN_DOMCTL_setvcpuaffinity
When browse code, I noticed if the op->u.vcpuaffinity.cpumap is NULL, a random 
value of new_affinity will be passed to vcpu_set_affinity(), as in followed 

I'm not sure if this is expected result. IMO, we should return -EINVAL if no 
cpu specified, as the return value at vcpu_set_affinity() for empty cpumap.

Did I missed anything?

    case XEN_DOMCTL_getvcpuaffinity:
        domid_t dom = op->domain;
        struct domain *d = rcu_lock_domain_by_id(dom);
        struct vcpu *v;
        cpumask_t new_affinity;
        if ( op->cmd == XEN_DOMCTL_setvcpuaffinity )
            xenctl_cpumap_to_cpumask(           >>>>> the new_affinity is not 
initialized for if cpumap==NULL
                &new_affinity, &op->u.vcpuaffinity.cpumap);
            ret = vcpu_set_affinity(v, &new_affinity);


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>