This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] [pv-ops domU] support MAXSMP

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] [pv-ops domU] support MAXSMP
From: Andrew Jones <drjones@xxxxxxxxxx>
Date: Fri, 18 Dec 2009 14:51:14 +0100
Cc: jeremy@xxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 18 Dec 2009 05:56:39 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B2B94850200007800026A03@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4B2B4BF3.1010507@xxxxxxxxxx> <4B2B625D02000078000269B3@xxxxxxxxxxxxxxxxxx> <4B2B585D.5000305@xxxxxxxxxx> <4B2B8234.50407@xxxxxxxxxx> <4B2B94850200007800026A03@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv: Gecko/20091109 Fedora/3.0-3.10.b4.fc12 Lightning/1.0pre Thunderbird/3.0b4
On 12/18/2009 02:41 PM, Jan Beulich wrote:
Andrew Jones<drjones@xxxxxxxxxx>  18.12.09 14:23>>>
Another note here is that the amount of stack allocation is the same
regardless of the value of num_processors. We're just creating a pointer
to this structure on the stack. sizeof is smart enough to pass the
appropriate dynamic size on to the mc call for validation though. So I
think all should be good with this patch.

Ah, okay. At least it'll be a clear BUG_ON() if an overflow happens. And
that's probably what you got before your patch?

That's right; "kernel BUG at arch/x86/xen/multicalls.c:209!"


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>