Re: [Xen-devel] [PATCH] [pv-ops domU] support MAXSMP

["Jan Beulich" <JBeulich@xxxxxxxxxx>]

>>> Andrew Jones <drjones@xxxxxxxxxx> 18.12.09 10:31 >>>
>The MAXSMP config option requires CPUMASK_OFFSTACK, which in turn
>requires we init the memory for the maps while we bringing up the cpus.
>MAXSMP also increases NR_CPUS to 4096. This increase in size exposed an
>issue in the argument construction for mulitcalls from
>xen_flush_tlb_others. The args should only need space for the actual
>number of cpus, which with xen is currently only up to 32.

I don't think new code should be making assumptions like this anymore,
since Xen already supports higher numbers (it's merely the tools which
so far don't). You're basically trading a compile time detectable large
value on stack for one that can grow large dynamically (and hence
require quite a bit more effort to debug, should it ever overrun the
stack).

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel