This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Paging and memory sharing for HVM guests

To: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Paging and memory sharing for HVM guests
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Thu, 17 Dec 2009 13:27:43 -0500
Cc: Patrick Colp <pjcolp@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, Grzegorz Milos <gm281@xxxxxxxxx>, Andrew Peace <Andrew.Peace@xxxxxxxxxxxxx>
Delivery-date: Thu, 17 Dec 2009 10:32:16 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B2A719E020000780002679C@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <db8ce2bd0912161514s7a162546gf7f5909db22e274c@xxxxxxxxxxxxxx> <20091217163845.GA26398@xxxxxxxxxxxxxxxxxxx> <4B2A719E020000780002679C@xxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.19 (2009-01-05)
On Thu, Dec 17, 2009 at 04:59:58PM +0000, Jan Beulich wrote:
> >>> Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> 17.12.09 17:38 >>>
> >1). The  "*mfnp |= 0x80000000U;" and "*mfnp |= 0xf0000000U;" should
> >    use a #define. Maybe copy over the #defines from the xen tree ?
> Did you find any defines in the tools sources for that? The only place I
> found this condition being checked at all was in xc_map_foreign_pages(),
> where it used hard-coded values. Or are you referring to the
> XEN_DOMCTL_PFINFO_* values? I'd say they're being mis-used when

Yes, those are the ones that I've gotten it from. Granted, as you said
they aren't wide enough for this. And it does look a bit unhealthy
to be writting those values in. I was thinking that that mmu.c should
probably have some code for this too to check if those MFNs
are no good.

> applied to the mfn array used by mmap-batch (including apparent
> pre-existing uses).

I am not that familiar with the grant driver to make a good judgment
on that. But I do think that upstream Linux folks would gag on this code
as "hacky".

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>