This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Paging and memory sharing for HVM guests

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Paging and memory sharing for HVM guests
From: Patrick Colp <pjcolp@xxxxxxxxx>
Date: Thu, 17 Dec 2009 12:22:27 -0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, Grzegorz Milos <gm281@xxxxxxxxx>, Andrew Peace <Andrew.Peace@xxxxxxxxxxxxx>
Delivery-date: Thu, 17 Dec 2009 12:22:54 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B2A91B0.5030908@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <db8ce2bd0912161514s7a162546gf7f5909db22e274c@xxxxxxxxxxxxxx> <4B2A8AC0.1080902@xxxxxxxx> <4B2A8FBE.4090000@xxxxxxxxx> <4B2A9178.2000404@xxxxxxxx> <4B2A91B0.5030908@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20090817)
OK. I've attached a patch to fix the include problem. I'll leave the xen/mem_event.h problem for now unless other people have it too.


Jeremy Fitzhardinge wrote:
On 12/17/2009 12:15 PM, Jeremy Fitzhardinge wrote:
On 12/17/2009 12:08 PM, Patrick Colp wrote:
That's odd. I just pulled a fresh copy of xen-unstable and built xen and the tools. Both compiled with no errors or problems. Maybe this is some sort of distro-dependent problem?

Possibly. I'm using Fedora 11 on this machine, and it also fails in Fedora 12. For the sleep() prototype, is it possible your versions headers are implicitly including unistd.h, or otherwise have a prototype for it?

And for the xen/mem_event.h problem, might you have that header installed somewhere?

Though I just did a clean+build and it found the header, so maybe it was something in the header symlink mess.

So just the sleep prototype problem.

Add missing unistd.h header file which causes the build to fail on some

Signed-off-by: Patrick Colp <Patrick.Colp@xxxxxxxxxx>

diff -r b47dfc7f5918 tools/memshr/bidir-daemon.c
--- a/tools/memshr/bidir-daemon.c       Thu Dec 17 09:21:56 2009 -0800
+++ b/tools/memshr/bidir-daemon.c       Thu Dec 17 12:19:57 2009 -0800
@@ -18,6 +18,7 @@
 #include <pthread.h>
 #include <inttypes.h>
+#include <unistd.h>
 #include "bidir-hash.h"
 #include "memshr-priv.h"
Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>