This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH][1/2] pvops-dom0: Xen acpi processor logic cleanu

To: "Yu, Ke" <ke.yu@xxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH][1/2] pvops-dom0: Xen acpi processor logic cleanup
From: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Date: Mon, 30 Nov 2009 12:05:39 -0800
Cc: "Brown, Len" <len.brown@xxxxxxxxx>, "'xen-devel@xxxxxxxxxxxxxxxxxxx'" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 30 Nov 2009 12:06:02 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D05DB80B95B23498C72C700BD6C2E0B36A73D50@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4D05DB80B95B23498C72C700BD6C2E0B369D687F@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4B0D7C1A.9050309@xxxxxxxx> <4D05DB80B95B23498C72C700BD6C2E0B369D6BE1@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4B0E3FF2.8060806@xxxxxxxx> <4D05DB80B95B23498C72C700BD6C2E0B36A73D50@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv: Gecko/20090922 Fedora/3.0-3.9.b4.fc12 Thunderbird/3.0b4
On 11/26/09 18:23, Yu, Ke wrote:
> I tried making xen code modular before, the issue here is the two-way 
> dependency among acpi processor driver (driver/acpi/processor_core.c) and xen 
> driver (driver/xen/acpi_processor.c). firstly, acpi processor driver depend 
> on xen driver routine processor_cntl_xen_notify(). Secondly, if xen driver 
> depend on some routine of acpi processor driver (e.g. 
> acpi_set_processor_driver as you mentioned), then there is two way dependency 
> between these two modules, which cannot pass compilation. so what I have done 
> in last patch is moving related code from xen part to acpi processor driver 
> part, to eliminate the xen->acpi processor dependency. 

Well, you can either make it a looser coupling by making the acpi->xen
call via a function pointer, or by using Kconfig to make sure that the
Xen code and the ACPI code are always compiled in a compatible way (ie,
both builtin or both modules).


Xen-devel mailing list