[Xen-devel] Re: [PATCH][1/2] pvops-dom0: Xen acpi processor logic cleanup

[Jeremy Fitzhardinge <jeremy@xxxxxxxx>]

On 11/26/09 18:23, Yu, Ke wrote:
> I tried making xen code modular before, the issue here is the two-way 
> dependency among acpi processor driver (driver/acpi/processor_core.c) and xen 
> driver (driver/xen/acpi_processor.c). firstly, acpi processor driver depend 
> on xen driver routine processor_cntl_xen_notify(). Secondly, if xen driver 
> depend on some routine of acpi processor driver (e.g. 
> acpi_set_processor_driver as you mentioned), then there is two way dependency 
> between these two modules, which cannot pass compilation. so what I have done 
> in last patch is moving related code from xen part to acpi processor driver 
> part, to eliminate the xen->acpi processor dependency. 

Well, you can either make it a looser coupling by making the acpi->xen
call via a function pointer, or by using Kconfig to make sure that the
Xen code and the ACPI code are always compiled in a compatible way (ie,
both builtin or both modules).

    J


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel