This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] RE: [PATCH][1/2] pvops-dom0: Xen acpi processor logic cleanu

To: Jeremy Fitzhardinge <jeremy@xxxxxxxx>
Subject: [Xen-devel] RE: [PATCH][1/2] pvops-dom0: Xen acpi processor logic cleanup
From: "Yu, Ke" <ke.yu@xxxxxxxxx>
Date: Thu, 26 Nov 2009 16:29:22 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "Brown, Len" <len.brown@xxxxxxxxx>, "'xen-devel@xxxxxxxxxxxxxxxxxxx'" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 26 Nov 2009 00:32:47 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4B0D7C1A.9050309@xxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4D05DB80B95B23498C72C700BD6C2E0B369D687F@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <4B0D7C1A.9050309@xxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acpt//aU1RFegq99Qfmnsymuz1qy3QAcWt3w
Thread-topic: [PATCH][1/2] pvops-dom0: Xen acpi processor logic cleanup
>Thanks, this looks like a big improvement.  I have some comments about
>the details though:
>    * Split this into 3 patches:
>          o revert the old Xen-specific changes
>          o add the new common code (which may just be
>            is_processor_apic_enabled())
>          o add the new Xen-specific code in a new file

Thanks for the comments. I split the original patch into three patch as you 
suggested. However, after it is done, I notice the original patch has already 
been checked in. so I just attach the three patch for your information, in case 
you still need that.

>    * Make acpi_processor_driver a pointer to the preferred driver
>      structure which defaults to the normal driver, and have some Xen
>      code re-point it to the Xen one during Xen setup, rather than
>      having an explicit Xen test in the core ACPI code

This approach will introduce another dependency between xen setup code and acpi 
processor driver module, and again cannot pass compiling when 
CONFIG_ACPI_PROCESSOR=m. so I would suggest to keep it as it is. How do you 

Best Regards

Attachment: 3_xen-acpi-new.patch
Description: 3_xen-acpi-new.patch

Attachment: 1_xen-acpi-revert.patch
Description: 1_xen-acpi-revert.patch

Attachment: 2_xen-acpi-common.patch
Description: 2_xen-acpi-common.patch

Xen-devel mailing list