This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] RE: Bug in CS 20073

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, Stephen Smalley <sds@xxxxxxxxxxxxx>
Subject: [Xen-devel] RE: Bug in CS 20073
From: "Zhang, Xiantao" <xiantao.zhang@xxxxxxxxx>
Date: Fri, 21 Aug 2009 21:31:57 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: Xen <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Fri, 21 Aug 2009 06:32:26 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C6B45B62.12A23%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1250856190.2390.23.camel@xxxxxxxxxxxxxxxxxxxxxxxxx> <C6B45B62.12A23%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcoiVtQA88VGmaipRLqAGjVPwQ0aBwACfUdEAAC3nTA=
Thread-topic: Bug in CS 20073
Keir Fraser wrote:
> On 21/08/2009 13:03, "Stephen Smalley" <sds@xxxxxxxxxxxxx> wrote:
>> On Thu, 2009-08-20 at 17:02 +0100, Keir Fraser wrote:
>>> Looks like a lock normally taken with irqs disabled may be being
>>> taken with irqs enabled. Which wouldn't be allowed but could be
>>> easy to fix. 
>> This appears to have been introduced by CS 20073, x86:  Implement
>> per-cpu vector for xen hypervisor.  It introduces mixed usage of
>> spin_lock() and spin_lock_irqsave() on the vector_lock, whereas
>> previously it was always spin_lock_irqsave().
> Xiantao, Can you make a patch for this? Any acquisition of the lock
> where irqs may not already be disabled must do spin_lock_irq or
> spin_lock_irqsave. 

Yes, I will work out a fix for that. :)

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>