This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: Bug in CS 20073

To: Stephen Smalley <sds@xxxxxxxxxxxxx>
Subject: [Xen-devel] Re: Bug in CS 20073
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Fri, 21 Aug 2009 14:10:42 +0100
Cc: Xen <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Zhang, Xiantao" <xiantao.zhang@xxxxxxxxx>
Delivery-date: Fri, 21 Aug 2009 06:11:10 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <1250856190.2390.23.camel@xxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcoiVtQA88VGmaipRLqAGjVPwQ0aBwACfUdE
Thread-topic: Bug in CS 20073
User-agent: Microsoft-Entourage/
On 21/08/2009 13:03, "Stephen Smalley" <sds@xxxxxxxxxxxxx> wrote:

> On Thu, 2009-08-20 at 17:02 +0100, Keir Fraser wrote:
>> Looks like a lock normally taken with irqs disabled may be being taken with
>> irqs enabled. Which wouldn't be allowed but could be easy to fix.
> This appears to have been introduced by CS 20073, x86:  Implement
> per-cpu vector for xen hypervisor.  It introduces mixed usage of
> spin_lock() and spin_lock_irqsave() on the vector_lock, whereas
> previously it was always spin_lock_irqsave().

Xiantao, Can you make a patch for this? Any acquisition of the lock where
irqs may not already be disabled must do spin_lock_irq or spin_lock_irqsave.

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>