This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Include in balloon page tracking only PFNs which

To: Gianluca Guida <gianluca.guida@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Include in balloon page tracking only PFNs which are marked as RAM in E820.
From: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Date: Thu, 20 Aug 2009 12:43:08 -0400
Cc: Gianluca Guida <Gianluca.Guida@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Konrad Rzeszutek Wilk <kliw@xxxxxxxxxx>
Delivery-date: Thu, 20 Aug 2009 09:49:36 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <19085.29617.299035.903514@xxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1250709149-4730-1-git-send-email-konrad.wilk@xxxxxxxxxx> <1250709149-4730-2-git-send-email-konrad.wilk@xxxxxxxxxx> <20090819191607.GA4798@xxxxxxxxxxxxxxxxxxx> <19085.29617.299035.903514@xxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.19 (2009-01-05)
On Thu, Aug 20, 2009 at 05:02:57PM +0100, Gianluca Guida wrote:
> Hi,
> Ok, by looking at this patch it's clear that you are testing with a
> kernel that tries to allow kernels to boot ballooned.
> In this case the patch is correct. Since the patch is actually
> reverted, I think we should wait to apply it until I succeed to
> reproduce the bug that caused Jeremy to revert it.

You are talking about the 7394b25905929a92e51771b832ee67b70ccebcf0 patch?
I will wait and if this patch is still needed I will send it out to 
with your style comment.

>  > > +                int is_ram = page_is_ram(pfn);
> Do you really need to declare this as a variable? couldn't you put the

Not at all. Right after I sent it out I realized it would have been looking
better without.

> expression in the if statement?

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>