WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Include in balloon page tracking only PFNs which

To: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Include in balloon page tracking only PFNs which are marked as RAM in E820.
From: Gianluca Guida <gianluca.guida@xxxxxxxxxx>
Date: Thu, 20 Aug 2009 17:02:57 +0100
Cc: Gianluca Guida <Gianluca.Guida@xxxxxxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Konrad Rzeszutek Wilk <kliw@xxxxxxxxxx>
Delivery-date: Thu, 20 Aug 2009 09:28:35 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20090819191607.GA4798@xxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1250709149-4730-1-git-send-email-konrad.wilk@xxxxxxxxxx> <1250709149-4730-2-git-send-email-konrad.wilk@xxxxxxxxxx> <20090819191607.GA4798@xxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hi,

Ok, by looking at this patch it's clear that you are testing with a
kernel that tries to allow kernels to boot ballooned.

In this case the patch is correct. Since the patch is actually
reverted, I think we should wait to apply it until I succeed to
reproduce the bug that caused Jeremy to revert it.

Only one style comment:

Konrad Rzeszutek Wilk writes:
 > On Wed, Aug 19, 2009 at 03:12:29PM -0400, Konrad Rzeszutek Wilk wrote:
 > > From: Konrad Rzeszutek Wilk <kliw@xxxxxxxxxx>
 > > 
 > > Signed-off-by: Konrad Rzeszutek Wilk <kliw@xxxxxxxxxx>
 > > ---
 > >  drivers/xen/balloon.c |    8 ++++++--
 > >  1 files changed, 6 insertions(+), 2 deletions(-)
 > > 
 > > diff --git a/drivers/xen/balloon.c b/drivers/xen/balloon.c
 > > index 168e61f..ef2edd8 100644
 > > --- a/drivers/xen/balloon.c
 > > +++ b/drivers/xen/balloon.c
 > > @@ -416,8 +416,12 @@ static int __init balloon_init(void)
 > >  
 > >    /* Initialise the balloon with excess memory space. */
 > >    for (pfn = xen_start_info->nr_pages; pfn < max_pfn; pfn++) {
 > > -          page = pfn_to_page(pfn);
 > > -          balloon_append(page);
 > > +                  int is_ram = page_is_ram(pfn);

Do you really need to declare this as a variable? couldn't you put the
expression in the if statement?

 > > +          if (is_ram) {
 > > +                  page = pfn_to_page(pfn);
 > > +                  if (PageReserved(page))
 > > +                          balloon_append(page);
 > > +          }
 > >    }
 > >  
 > >    target_watch.callback = watch_target;
 > > -- 
 > > 1.6.2.5


Thanks,
Gianluca

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel