This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] xen: make (set|get)_xen_guest_handle available

To: Christoph Egger <Christoph.Egger@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xen: make (set|get)_xen_guest_handle available
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 30 Jul 2009 14:24:33 +0100
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 30 Jul 2009 06:26:33 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <200907301234.38307.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcoRAV9WmoNqhIVvREm93uWS+/kfbgAF7QCZ
Thread-topic: [Xen-devel] [PATCH] xen: make (set|get)_xen_guest_handle available
User-agent: Microsoft-Entourage/
On 30/07/2009 11:34, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

>> Actually I don't see why you'd have code like this. *You*, the guest, gets
>> to specify __XEN_INTERFACE_VERSION__ -- that is the point of it -- so
>> ifdef'ing based on it in the guest is stupid.
>> Just specify __XEN_INTERFACE_VERSION__ to be recent enough to have the
>> guest handles, and then remove your ifdefs. Simple.
> The point is to keep backward compatibility. The patch makes Xen more friendly
> with using the old non-structured guest handler if the user wants.
> NetBSD offers both way to build & run it with either using the old or new
> interface. This allows a smooth migration.

Am I going to regret asking: Why? You only need to pick one API version
(__XEN_INTERFACE_VERSION__) -- the resulting binaries will work with any Xen
3.x (since we guarantee ABI compatibility).

 -- Keir

Xen-devel mailing list