This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] xen: make (set|get)_xen_guest_handle available

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xen: make (set|get)_xen_guest_handle available
From: Christoph Egger <Christoph.Egger@xxxxxxx>
Date: Thu, 30 Jul 2009 12:34:38 +0200
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 30 Jul 2009 03:35:23 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C69730FC.10EF6%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <C69730FC.10EF6%keir.fraser@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.7
On Thursday 30 July 2009 12:14:04 Keir Fraser wrote:
> On 30/07/2009 10:12, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:
> > Make (set|get)_xen_guest_handle() always available.
> > This avoids code snippets in the guest like this:
> >
> > #if __XEN_ITNERFACE_VERSION__ >= 0x00030201
> > set_xen_guest_handle(hnd, val);
> > #else
> > hnd = val;
> > #endif
> Actually I don't see why you'd have code like this. *You*, the guest, gets
> to specify __XEN_INTERFACE_VERSION__ -- that is the point of it -- so
> ifdef'ing based on it in the guest is stupid.
> Just specify __XEN_INTERFACE_VERSION__ to be recent enough to have the
> guest handles, and then remove your ifdefs. Simple.

The point is to keep backward compatibility. The patch makes Xen more friendly
with using the old non-structured guest handler if the user wants.

NetBSD offers both way to build & run it with either using the old or new
interface. This allows a smooth migration.


---to satisfy European Law for business letters:
Advanced Micro Devices GmbH
Karl-Hammerschmidt-Str. 34, 85609 Dornach b. Muenchen
Geschaeftsfuehrer: Thomas M. McCoy, Giuliano Meroni
Sitz: Dornach, Gemeinde Aschheim, Landkreis Muenchen
Registergericht Muenchen, HRB Nr. 43632

Xen-devel mailing list