This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] xen: make (set|get)_xen_guest_handle available

To: Christoph Egger <Christoph.Egger@xxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xen: make (set|get)_xen_guest_handle available
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Thu, 30 Jul 2009 11:14:04 +0100
Delivery-date: Thu, 30 Jul 2009 03:14:38 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <200907301112.15209.Christoph.Egger@xxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcoQ9eyK0m4g/BrDSgGR+AoGoPFhDwACIqaG
Thread-topic: [Xen-devel] [PATCH] xen: make (set|get)_xen_guest_handle available
User-agent: Microsoft-Entourage/
On 30/07/2009 10:12, "Christoph Egger" <Christoph.Egger@xxxxxxx> wrote:

> Make (set|get)_xen_guest_handle() always available.
> This avoids code snippets in the guest like this:
> #if __XEN_ITNERFACE_VERSION__ >= 0x00030201
> set_xen_guest_handle(hnd, val);
> #else
> hnd = val;
> #endif

Actually I don't see why you'd have code like this. *You*, the guest, gets
to specify __XEN_INTERFACE_VERSION__ -- that is the point of it -- so
ifdef'ing based on it in the guest is stupid.

Just specify __XEN_INTERFACE_VERSION__ to be recent enough to have the guest
handles, and then remove your ifdefs. Simple.

 -- Keir

Xen-devel mailing list