This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] dom0 hang

To: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] dom0 hang
From: Mukesh Rathor <mukesh.rathor@xxxxxxxxxx>
Date: Tue, 07 Jul 2009 11:28:25 -0700
Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, "Kurt C. Hackel" <kurt.hackel@xxxxxxxxxx>, "Tian, Kevin" <kevin.tian@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Yu, Ke" <ke.yu@xxxxxxxxx>
Delivery-date: Tue, 07 Jul 2009 11:29:07 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <C678B6D7.EFC1%keir.fraser@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Oracle Corp
References: <C678B6D7.EFC1%keir.fraser@xxxxxxxxxxxxx>
Reply-to: mukesh.rathor@xxxxxxxxxx
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20090320)

Keir Fraser wrote:
On 07/07/2009 08:14, "Yu, Ke" <ke.yu@xxxxxxxxx> wrote:

BTW, why can't the tick be suspended when csched_schedule() concludes
it's idle vcpu before returning? won't that would make it less intrusive.
The tick suspend can be put in csched_schedule, but the suspend/resume logic
is still needed in acpi_processor_idle anyway, due to another dbs_timer
suspend/resume. The intention here is to make acpi_processor_idle the central
place for timers which are stoppable during idle period. If there is other
stoppable timer in the future, it can be easily added to acpi_processor_idle.
So it is clean to keep current logic. and as long as we carefully not over
doing the softirq, it looks not so intrusive. How do you think?

I think the approach is fine. I also already applied your patch since it is
obviously a good bug fix, even if it doesn't fix Mukesh's bug. And I fixed
the comment at the same time. And I backported it for Xen 3.4.1.

 -- Keir

It fixes my bug.


Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>