This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] dom0 hang

To: "Yu, Ke" <ke.yu@xxxxxxxxx>, "mukesh.rathor@xxxxxxxxxx" <mukesh.rathor@xxxxxxxxxx>
Subject: Re: [Xen-devel] dom0 hang
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Tue, 07 Jul 2009 08:24:55 +0100
Cc: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>, "Kurt C. Hackel" <kurt.hackel@xxxxxxxxxx>, "Tian, Kevin" <kevin.tian@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 07 Jul 2009 00:25:27 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <4D05DB80B95B23498C72C700BD6C2E0B2F9F62EC@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acn+tZ24wQgV+EHPRx6jFo5ZCiRy2QAFY0twAAI23qA=
Thread-topic: [Xen-devel] dom0 hang
User-agent: Microsoft-Entourage/
On 07/07/2009 08:14, "Yu, Ke" <ke.yu@xxxxxxxxx> wrote:

>> BTW, why can't the tick be suspended when csched_schedule() concludes
>> it's idle vcpu before returning? won't that would make it less intrusive.
> The tick suspend can be put in csched_schedule, but the suspend/resume logic
> is still needed in acpi_processor_idle anyway, due to another dbs_timer
> suspend/resume. The intention here is to make acpi_processor_idle the central
> place for timers which are stoppable during idle period. If there is other
> stoppable timer in the future, it can be easily added to acpi_processor_idle.
> So it is clean to keep current logic. and as long as we carefully not over
> doing the softirq, it looks not so intrusive. How do you think?

I think the approach is fine. I also already applied your patch since it is
obviously a good bug fix, even if it doesn't fix Mukesh's bug. And I fixed
the comment at the same time. And I backported it for Xen 3.4.1.

 -- Keir

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>