This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] 2.6.30 dom0 Xen patches

To: Andrew Lyon <andrew.lyon@xxxxxxxxx>, Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] 2.6.30 dom0 Xen patches
From: Boris Derzhavets <bderzhavets@xxxxxxxxx>
Date: Thu, 2 Jul 2009 08:51:13 -0700 (PDT)
Cc: Xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 02 Jul 2009 08:56:04 -0700
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1246549874; bh=rva/hTxSUIcxEpP8locj9HVBirx+d9u0Qfc6CQl6UmY=; h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:MIME-Version:Content-Type; b=xoIZHrXoC/ErKGcbIDhBNxtf5/7dO3RZUkewyPCXrO4+J6j+DL0y60d1kadqsq5wxhCseCOtE3rFVi3VLXt+KsuKx0VeQ1xmQizb4ps99ei3qYZSgbVT1FMl0gBKrs8MdIMa8JUmAAHgDLa/0Bg71i0s9xa+2SaNFJvXY8qfYLc=
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=Message-ID:X-YMail-OSG:Received:X-Mailer:Date:From:Subject:To:Cc:MIME-Version:Content-Type; b=WViK1IGucicCz1DiQ8EbWma1Y3zOVi29KDDAUTTj8ipD22Tk7hCIvt0ZiAnyEbUhcNxYnyVOeKJcMBYgIwinSKM8G7Jyc/oggO45YeUzHKZcZ3fQc42nnzcSB0DcZuxwrxMshy+GCDLIhNJ2v/sJRhJt4OXTQcsTQljcVtHkpBc=;
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Not sure i did right thing, i've edited 60036_xen3-patch-2.6.30.patch1 as follows:-

@@ -3957,7 +3982,29 @@ void __init probe_nr_irqs_gsi(void)
     printk(KERN_DEBUG "nr_irqs_gsi: %d\n", nr_irqs_gsi);
+int __init arch_probe_nr_irqs(void)
+    int nr;
+    if (nr_irqs > (NR_VECTORS * nr_cpu_ids))
+        nr_irqs = NR_VECTORS * nr_cpu_ids;
+    nr = nr_irqs_gsi + 8 * nr_cpu_ids;
+#if defined(CONFIG_PCI_MSI) || defined(CONFIG_HT_IRQ)
+    /*
+     * for MSI and HT dyn irq
+     */
+    nr += nr_irqs_gsi * 16;

allows to compile unbind_from_irq() in ./linux-2drivers/xen/core/evtchn.c with no errors and xenified kernel been built seems to work OK
Make menuconfig didn't require any changes to enable Xen Dom0 support .

In .config :-

Before build CONFIG_SPARSE_IRQ=y
After build # CONFIG_SPARSE_IRQ is not set


--- On Thu, 7/2/09, Jan Beulich <JBeulich@xxxxxxxxxx> wrote:

From: Jan Beulich <JBeulich@xxxxxxxxxx>
Subject: Re: [Xen-devel] 2.6.30 dom0 Xen patches
To: "Andrew Lyon" <andrew.lyon@xxxxxxxxx>
Cc: "Xen-devel" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Date: Thursday, July 2, 2009, 2:53 AM

>>> Andrew Lyon <andrew.lyon@xxxxxxxxx> 01.07.09 19:15 >>>
>I have rebased the xen-patches from opensuse
>kernel-source-2.6.30-50.1.src.rpm so that they can be applied to
>vanilla 2.6.30, the usual patches tarball and gentoo ebuild are
>available at http://code.google.com/p/gentoo-xen-kernel/downloads/list
>, if you are not using Gentoo simply apply the patches in numeric
>Some notes:
>both dom0 and domU require CONFIG_SPARSE_IRQ=y and CONFIG_HOTPLUG=y
>64 bit dom0/domU requires CONFIG_IA32_EMULATION=y

May I ask why you found the first and third ones to be necessary? Unless
it's because of the conditional in the loop right after the commen "Zap
stats across IRQ changes of use." in unbind_from_irq(), which I fixed a
few days ago, but didn't push out to our internal repo so far. (The fix
is to change the dependency from CONFIG_SPARSE_IRQ to
CONFIG_GENERIC_HARDIRQS in the 2.6.30 patch.)

The second one seems less meaningful, as I wouldn't think anyone would
build a general use (Xen) kernel with EMBEDDED=y, and HOTPLUG is not
user selectable without EMBEDDED.

May I also ask for you to let us know about fixes to the patches that you
find necessary which aren't just due to you applying them to plain 2.6.30?

Thanks, Jan

Xen-devel mailing list

Xen-devel mailing list