This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel][PATCH]ioemu:fix up error when using qemu-img-xen to crea

Li, Xin writes ("RE: [Xen-devel][PATCH]ioemu:fix up error when using 
qemu-img-xen to create img"):
> Any comments on this patch? it's a block issue to our QA test.

Sorry to delay replying to this.

> >+    else
> >+        drv = &bdrv_raw;

This appears to reintroduce the image format vulnerability.  Are you
sure it's right ?

The effect of your patch seems to be in this case:
  * the filename does not refer to a block device
  * the format is not specified in the filename
  * the actual contents of the image is not autodetected as any
    image format (eg, qcow or qcow2)
In that case, without your patch, the open fails.  With your patch,
the file is opened with bdrv_raw.


Xen-devel mailing list