This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


RE: [Xen-devel][PATCH]ioemu:fix up error when using qemu-img-xen to crea

To: "Zhang, Yang" <yang.zhang@xxxxxxxxx>, Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: RE: [Xen-devel][PATCH]ioemu:fix up error when using qemu-img-xen to create img
From: "Li, Xin" <xin.li@xxxxxxxxx>
Date: Mon, 27 Apr 2009 11:13:18 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Sun, 26 Apr 2009 20:14:31 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <10C63FAD690C13458F0B32BCED571F1412A2344B@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <10C63FAD690C13458F0B32BCED571F1412A2344B@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcnCH9tiMvIyR9Q3TzutpeAOyhDLFwExfuJw
Thread-topic: [Xen-devel][PATCH]ioemu:fix up error when using qemu-img-xen to create img
Hi Ian,
Any comments on this patch? it's a block issue to our QA test.

>-----Original Message-----
>From: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>[mailto:xen-devel-bounces@xxxxxxxxxxxxxxxxxxx] On Behalf Of Zhang, Yang
>Sent: Tuesday, April 21, 2009 9:24 AM
>To: Ian Jackson
>Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
>Subject: [Xen-devel][PATCH]ioemu:fix up error when using qemu-img-xen to
>create img
>If find_protocol() can not find the the drv. The caller should give
>a default value.
>Signed-off-by: Yang Zhang <yang.zhang@xxxxxxxxx>
>diff --git a/block.c b/block.c
>index 8a0e8b2..3e84707 100644
>--- a/block.c
>+++ b/block.c
>@@ -306,6 +306,8 @@ static BlockDriver *find_image_format(const char
>     /* no need to test disk image format if the filename told us */
>     if (drv != NULL)
>         return drv;
>+    else
>+        drv = &bdrv_raw;
>     ret = bdrv_file_open(&bs, filename, BDRV_O_RDONLY);
>     if (ret < 0)

Xen-devel mailing list