This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel][PATCH]ioemu:fix up error when using qemu-img-xen to create i

To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
Subject: [Xen-devel][PATCH]ioemu:fix up error when using qemu-img-xen to create img
From: "Zhang, Yang" <yang.zhang@xxxxxxxxx>
Date: Tue, 21 Apr 2009 09:24:03 +0800
Accept-language: en-US
Acceptlanguage: en-US
Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Mon, 20 Apr 2009 18:27:24 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcnCH9tiMvIyR9Q3TzutpeAOyhDLFw==
Thread-topic: [Xen-devel][PATCH]ioemu:fix up error when using qemu-img-xen to create img
If find_protocol() can not find the the drv. The caller should give
a default value.

Signed-off-by: Yang Zhang <yang.zhang@xxxxxxxxx>

diff --git a/block.c b/block.c
index 8a0e8b2..3e84707 100644
--- a/block.c
+++ b/block.c
@@ -306,6 +306,8 @@ static BlockDriver *find_image_format(const char *filename)
     /* no need to test disk image format if the filename told us */
     if (drv != NULL)
         return drv;
+    else 
+        drv = &bdrv_raw;
     ret = bdrv_file_open(&bs, filename, BDRV_O_RDONLY);
     if (ret < 0)

Attachment: fix_qemu-img-xen_can_not_create_img.patch
Description: fix_qemu-img-xen_can_not_create_img.patch

Xen-devel mailing list