 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] Fix domheap structure allocation when NUMA=on
| To: | Jan Beulich <jbeulich@xxxxxxxxxx>, Xiaowei Yang <xiaowei.yang@xxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] Fix domheap structure allocation when NUMA=on |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Fri, 20 Mar 2009 09:32:15 +0000 |
| Cc: | "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Fri, 20 Mar 2009 02:32:47 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <49C36F81.76E4.0078.0@xxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcmpPe/bG8Ly/9/MS3idIpuUhwMGjAAANFEG |
| Thread-topic: | [Xen-devel] [PATCH] Fix domheap structure allocation when NUMA=on |
| User-agent: | Microsoft-Entourage/12.15.0.081119 |
On 20/03/2009 09:27, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote: >> Since DIRECTMAP_VIRT_END is always the following byte not the last byte, it >> sounds like you think the page_alloc.c chunk is not needed at all. I'll just >> check in the header fix for now. > > No, that chunk is necessary afaics - as I said I agree to Xiaowei's diagnosis > that virt_to_mfn() should not be used on DIRECTMAP_VIRT_END alone. > Subtracting 1 from it, and then adding back 1 to the result is indeed what > I think is the right thing to do here. Ah... virt_to_mfn() has a discontinuity at DIRECTMAP_VIRT_END. I get you. I'll apply that chunk as a separate changeset then. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] Re: [Patch 1/3]RAS(Part II)--Intel MCA enalbing in XEN, Keir Fraser |
|---|---|
| Next by Date: | Re: [Xen-devel] Re: [Patch 1/3]RAS(Part II)--Intel MCA enalbing in XEN, Christoph Egger |
| Previous by Thread: | Re: [Xen-devel] [PATCH] Fix domheap structure allocation when NUMA=on, Jan Beulich |
| Next by Thread: | Re: [Xen-devel] [PATCH] Fix domheap structure allocation when NUMA=on, Yang, Xiaowei |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
