 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] Fix domheap structure allocation when NUMA=on
| To: | Jan Beulich <jbeulich@xxxxxxxxxx>, Xiaowei Yang <xiaowei.yang@xxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] Fix domheap structure allocation when NUMA=on |
| From: | Keir Fraser <keir.fraser@xxxxxxxxxxxxx> |
| Date: | Fri, 20 Mar 2009 08:56:18 +0000 |
| Cc: | "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Fri, 20 Mar 2009 01:56:46 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <49C36646.76E4.0078.0@xxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcmpOJdpS7Y1pZqfQ3qch1JSl4LtqwAASQJV |
| Thread-topic: | [Xen-devel] [PATCH] Fix domheap structure allocation when NUMA=on |
| User-agent: | Microsoft-Entourage/12.15.0.081119 |
On 20/03/2009 08:47, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote: > virt_to_mfn(DIRECTMAP_VIRT_END - 1) is equal to > > Depending on whether DIRECTMAP_VIRT_END is the last byte or the first > following byte. Using "- 1" avoids such a dependency. > >> virt_to_mfn(DIRECTMAP_VIRT_END - PAGE_SIZE). Why +1? We use '<=' here. > > Because on the left side of the comparison we also calculate the first > following mfn, not the last included one. Since DIRECTMAP_VIRT_END is always the following byte not the last byte, it sounds like you think the page_alloc.c chunk is not needed at all. I'll just check in the header fix for now. -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] Re: [Patch 1/3]RAS(Part II)--Intel MCA enalbing in XEN, Keir Fraser |
|---|---|
| Next by Date: | Re: [Xen-devel] Re: [PATCH] Support swap a page from user space tools -- Was RE: [RFC][PATCH] Basic support for page offline, Keir Fraser |
| Previous by Thread: | Re: [Xen-devel] [PATCH] Fix domheap structure allocation when NUMA=on, Jan Beulich |
| Next by Thread: | Re: [Xen-devel] [PATCH] Fix domheap structure allocation when NUMA=on, Jan Beulich |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
