 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] Do not set page's count_info directly
| To: | Tim Deegan <Tim.Deegan@xxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] Do not set page's count_info directly |
| From: | Gianluca Guida <glguida@xxxxxxxxx> |
| Date: | Thu, 5 Mar 2009 13:45:48 +0100 |
| Cc: | "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Gianluca Guida <Gianluca.Guida@xxxxxxxxxxxxx>, "Jiang, Yunhong" <yunhong.jiang@xxxxxxxxx>, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx> |
| Delivery-date: | Thu, 05 Mar 2009 04:46:13 -0800 |
| Dkim-signature: | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:cc:content-type :content-transfer-encoding; bh=ZrIF14r2t7ARbY6fIKW2wxW4NbqcmaRdPz+Gt6D2Gaw=; b=lLpsaeQJiahk8B4sFNiBjWeODpZjRhObaZ9VXPub/cPC6e8pLUrH2IwhvxQc/w97n/ yaUqrX6GSZHNiQKSs4icd7jCAlVzOL3zGDHCOK0UhYVmHM8l7UIJvWmSXGbgucn6tF2L 7AqiQ/0cCO6uA3s/EQS7OZJtAgQO25nG8k5u4= |
| Domainkey-signature: | a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=jI3Z6dVJm6m/fza18jhmL9Dxq1GxgiD1Zh20weQX5Mz926MCTQLpVbcjazk2KC6hOv 4NrqV+oOY5phF/W3N9Eprh/Y5eDlBq+hBgcR9I3ofSoh+b9bUtKmA3UKP4aURtFHqhvA 2yPlF6wD0tiLDf34SXy8T8Gvy0ss8IO6zOcZE= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <20090305123853.GC6322@xxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <E2263E4A5B2284449EEBD0AAB751098401C7CE8E0E@xxxxxxxxxxxxxxxxxxxxxxxxxxxx> <f8877f640903050432w4d326bd8r601d350ca20e6fc4@xxxxxxxxxxxxxx> <20090305123853.GC6322@xxxxxxxxxxxxxxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On Thu, Mar 5, 2009 at 1:38 PM, Tim Deegan <Tim.Deegan@xxxxxxxxxx> wrote:
> The check doesn't tell you it's a shadow page -- it just tells you it's
> *not* allocated in another way. Checking with the mask is OK here,
> perhaps with a comment change.
Yes, but this is what the code (in the shadow code) intends to check.
My complete plan is to have this macro and restore the idea of having
a flag for shadow pages because, as for now, the fact that we can't
distinguish clearly a shadow page should be considered a sort of bug,
given the code assumptions. Or at least a good basis for future bugs.
Thanks,
Gianluca
--
It was a type of people I did not know, I found them very strange and
they did not inspire confidence at all. Later I learned that I had been
introduced to electronic engineers.
E. W. Dijkstra
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
| Previous by Date: | Re: [Xen-devel] [rfc 00/18] ioemu: use devfn instead of slots as the unit for passthrough, Keir Fraser |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH] Do not set page's count_info directly, Keir Fraser |
| Previous by Thread: | Re: [Xen-devel] [PATCH] Do not set page's count_info directly, Tim Deegan |
| Next by Thread: | Re: [Xen-devel] [PATCH] Do not set page's count_info directly, Keir Fraser |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
