WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [PATCH] Re: about fixup_page_fault

To: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] Re: about fixup_page_fault
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 17 Dec 2008 11:37:15 +0000
Cc: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Yang, Xiaowei" <xiaowei.yang@xxxxxxxxx>, Gianluca Guida <gianluca.guida@xxxxxxxxxxxxx>
Delivery-date: Wed, 17 Dec 2008 03:37:29 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20081217111910.GL460@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AclgO88P3JXdVST7Jk28rM2xogopCA==
Thread-topic: [PATCH] Re: about fixup_page_fault
User-agent: Microsoft-Entourage/12.14.0.081024
Applied as c/s 18927, thanks. Will consider for backport to 3.3.2 if it
holds up okay in xen-unstable.

 -- Keir

On 17/12/2008 11:19, "Tim Deegan" <Tim.Deegan@xxxxxxxxxx> wrote:

> Don't ever call the shadow code to fix a page fault in an external-mode
> guest if the fault came from Xen; it would be making changes to the
> wrong pagetables, potentially causing a pagefault loop in Xen.
> 
> Signed-off-by: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
> 
> 
> At 11:08 +0000 on 17 Dec (1229512101), Keir Fraser wrote:
>> I certainly think that something like the patch you proposed would cause a
>> better failure mode.
>> 
>> Kevin: Can you try out what Tim proposed and if it indeed makes things
>> better (at least, you get a proper crash!) we should get that checked in.
>> 
>>  -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel