[Xen-devel] Re: about fixup_page_fault

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 17/12/2008 10:58, "Keir Fraser" <keir.fraser@xxxxxxxxxxxxx> wrote:

> On 17/12/2008 10:53, "Tim Deegan" <Tim.Deegan@xxxxxxxxxx> wrote:
> 
>> At 09:04 +0000 on 17 Dec (1229504644), Keir Fraser wrote:
>>> A Xen fault shouldn't cause a lookup in guest tables for HVM guests.
>> 
>> Looks like it does, though. :(  The check in fixup_page_fault should
>> probably be more like:
> 
> But wouldn't this just cause an infinite loop? Since shadow code would fix up
> the fault in the guest shadow tables, which the hypervisor is not running on?

For clarity: I don't mean your patch would cause this. I mean the existing
code would have this behaviour, if this were the problem.

If you still think a patch is needed here then please send it along.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel