WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: about fixup_page_fault

To: Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Subject: [Xen-devel] Re: about fixup_page_fault
From: Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Date: Wed, 17 Dec 2008 11:08:21 +0000
Cc: "Tian, Kevin" <kevin.tian@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, "Yang, Xiaowei" <xiaowei.yang@xxxxxxxxx>, Gianluca Guida <gianluca.guida@xxxxxxxxxxxxx>
Delivery-date: Wed, 17 Dec 2008 03:08:45 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20081217110439.GJ460@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AclgN8WEuPjriPaywkiHY6m5zkZ3Uw==
Thread-topic: about fixup_page_fault
User-agent: Microsoft-Entourage/12.14.0.081024
On 17/12/2008 11:04, "Tim Deegan" <Tim.Deegan@xxxxxxxxxx> wrote:

>>> At 09:04 +0000 on 17 Dec (1229504644), Keir Fraser wrote:
>>>> A Xen fault shouldn't cause a lookup in guest tables for HVM guests.
>>> 
>>> Looks like it does, though. :(  The check in fixup_page_fault should
>>> probably be more like:
>> 
>> But wouldn't this just cause an infinite loop?
> 
> I thought that was what Kevin was reporting.

Oh yes, so he was. Duh. :-)

>> Since shadow code would fix up the fault in the guest shadow tables,
>> which the hypervisor is not running on?
> 
> Yes, exactly.  But it would only do that for faulting accesses from Xen
> that (a) weren't fixed up by any of the other mechanism, and (b)
> happened to be to addresses that were mapped in the guest tables.  And
> Xen would never do such a thing. :)

I certainly think that something like the patch you proposed would cause a
better failure mode.

Kevin: Can you try out what Tim proposed and if it indeed makes things
better (at least, you get a proper crash!) we should get that checked in.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel