WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[PATCH] fix ia64 breakage with PHYSDEVOP_pirq_eoi_mfn (was Re: [Xen-deve

To: "Isaku Yamahata" <yamahata@xxxxxxxxxxxxx>
Subject: [PATCH] fix ia64 breakage with PHYSDEVOP_pirq_eoi_mfn (was Re: [Xen-devel] [PATCH 2/2] linux/x86: use shared page indicating the need for an EOI notification)
From: "Jan Beulich" <jbeulich@xxxxxxxxxx>
Date: Wed, 03 Dec 2008 07:58:56 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>
Delivery-date: Tue, 02 Dec 2008 23:58:19 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <20081203020720.GA15798%yamahata@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <492FCF0D.76E4.0078.0@xxxxxxxxxx> <20081203020720.GA15798%yamahata@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
>>> Isaku Yamahata <yamahata@xxxxxxxxxxxxx> 03.12.08 03:07 >>>
>Hi Jan. Thank you for taking care of not breaking existing code.
>However there is an ia64 specific issue in this patch.
>Here is the patch to fix it.

I'm sorry for that, I really tried to not break ia64.

>And I have an issue:
>MFN is passed from a guest to the VMM to indicate a page in guest.
>However I think GMFN should be used, instead of MFN like
>grant table, xenoprof and other hypercalls.
>I'll post two patches to rename the related stuff.

Hmm, I know too little about ia64 Xen to understand the significance of
that difference.

>evtchn, physdev: fix pirq_eoi_mfn for IA64 support.
>
>On ia64, global variables aren't in identity mapping area (i.e. kaddr)
>so that there is no relationship between its virtual address and
>its physical address. Thus virt_to_bus() can't be applied to them.
>So introduce arbitrary_virt_to_bus() to wrap arch dependent function
>and make use of it.

The same applies to x86-64, but virt_to_bus() (or rather the underlying
virt_to_phys()) is prepared to deal with that situation. So it rather sounds
like a shortcoming of the ia64 variant to me...

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>