This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [Qemu-devel] [PATCH 1/7] xen: groundwork for xen support

To: Blue Swirl <blauwirbel@xxxxxxxxx>
Subject: [Xen-devel] Re: [Qemu-devel] [PATCH 1/7] xen: groundwork for xen support
From: Gerd Hoffmann <kraxel@xxxxxxxxxx>
Date: Mon, 04 Aug 2008 20:01:37 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, qemu-devel@xxxxxxxxxx
Delivery-date: Mon, 04 Aug 2008 11:02:17 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <f43fc5580808040934p187107ffu1b035c5297c1b25a@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1217865045-10722-1-git-send-email-kraxel@xxxxxxxxxx> <1217865045-10722-2-git-send-email-kraxel@xxxxxxxxxx> <f43fc5580808040934p187107ffu1b035c5297c1b25a@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20080501)
Blue Swirl wrote:
> On 8/4/08, Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote:
>>  - allow xenpv machines run without disk and kernel specified
>>   by adding a nodisk_ok field to QEMUMachine.
> Nice idea, this would be a useful feature by itself.

Yes, some embedded devices probably can use that too according to the
source code comment.  Guess thats why anthony suggested to do it that
way, and I liked the idea too, so I just did ;)

>>  +  $(XEN_OBJS) : CFLAGS += -Wall -Wmissing-prototypes -Wstrict-prototypes
> These aren't needed for Xen. Though I wonder why at least -Wall
> -Wstrict-prototypes could not be added globally.

IIRC I tried to turn them on globally and found myself swamped with
warnings.  So I took the easy way out and enabled them only for the xen
bits I'm working on.  I like those warnings, they catch sloppyness and
help writing clean code.  They are in no way required though.  We can
add them globally nevertheless, I can keep them as local patch, I don't
mind much.

>>  +    if (-1 != xen_present)
> This style looks alien to me. Do you really find it readable?

Bad habit.  gcc warns these days on "if (foo = 42)", so the reason to
write "if (42 = foo)" is gone.  I'm still doing that for -- say --
historical reasons?



Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>