This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [Qemu-devel] [PATCH 5/7] xen: add block device backend d

To: qemu-devel@xxxxxxxxxx
Subject: [Xen-devel] Re: [Qemu-devel] [PATCH 5/7] xen: add block device backend driver.
From: Anthony Liguori <anthony@xxxxxxxxxxxxx>
Date: Mon, 04 Aug 2008 12:46:14 -0500
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Gerd Hoffmann <kraxel@xxxxxxxxxx>
Delivery-date: Mon, 04 Aug 2008 10:47:21 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <f43fc5580808041026t49c8962fhe6ef926608e3db6c@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1217865045-10722-1-git-send-email-kraxel@xxxxxxxxxx> <1217865045-10722-6-git-send-email-kraxel@xxxxxxxxxx> <f43fc5580808041026t49c8962fhe6ef926608e3db6c@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20080501)
Blue Swirl wrote:
On 8/4/08, Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote:
 +/* i386 protocol version */
 +#pragma pack(push, 4)

What's wrong with __attribute__(__aligned__)?

 + *  FIXME: the code is designed to handle multiple outstanding
 + *  requests (using aio or using threads), which isn't used right
 + *  now due to limitations of the qemu block driver interface.

Yes, what happened to vectored DMA patches?

Believe it or not, they were hurting performance in KVM. Passing a vector to the block layer will force the IO operation to be split up into multiple requests that are all executed in serial (since QEMU only supports 1 outstanding request at a time). Copying the vectored IO to a linear buffer increased performance significantly because it avoided this serialization.

The block layer needs some refactoring to support proper vectored AIO operations before a zero-copy API will make sense from a performance perspective.


Anthony Liguori

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>