WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [Qemu-devel] [PATCH 4/7] xen: add framebuffer backend dr

To: Blue Swirl <blauwirbel@xxxxxxxxx>
Subject: [Xen-devel] Re: [Qemu-devel] [PATCH 4/7] xen: add framebuffer backend driver
From: Gerd Hoffmann <kraxel@xxxxxxxxxx>
Date: Mon, 04 Aug 2008 20:20:25 +0200
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, qemu-devel@xxxxxxxxxx
Delivery-date: Mon, 04 Aug 2008 11:21:46 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <f43fc5580808041009g727f9f59gff94e27decfe2d25@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1217865045-10722-1-git-send-email-kraxel@xxxxxxxxxx> <1217865045-10722-5-git-send-email-kraxel@xxxxxxxxxx> <f43fc5580808041009g727f9f59gff94e27decfe2d25@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 2.0.0.14 (X11/20080501)
Blue Swirl wrote:
> On 8/4/08, Gerd Hoffmann <kraxel@xxxxxxxxxx> wrote:
>>  +const unsigned char atkbd_set2_keycode[512] = {
> 
> Missing "static"?

Yep, I'll fix it up.

>>  +       for (i = 0; i < 128; i++) {
>>  +           scancode2linux[i] = atkbd_set2_keycode[atkbd_unxlate_table[i]];
>>  +           scancode2linux[i | 0x80] =
>>  +               atkbd_set2_keycode[atkbd_unxlate_table[i] | 0x80];
>>  +       }
> 
> Can't these table be calculated so that this initial run-time lookup
> is not needed?

Should be doable, yes.

> The framebuffer does not use dirty memory detection. Is this
> intentional? I understand that in Xen that's not possible.

The guest frontend driver does that and sends the info to the backend
driver (XENFB_TYPE_UPDATE messages).

cheers,
  Gerd

-- 
http://kraxel.fedorapeople.org/xenner/

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>