This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH][HVM] pass-through PCI device hotplug support

To: "Zhai, Edwin" <edwin.zhai@xxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH][HVM] pass-through PCI device hotplug support
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Sun, 17 Feb 2008 16:43:27 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Sun, 17 Feb 2008 08:42:58 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20080217153439.GD21201@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AchxhDgMdpM+1t13EdydtAAWy6hiGQ==
Thread-topic: [PATCH][HVM] pass-through PCI device hotplug support
User-agent: Microsoft-Entourage/
On 17/2/08 15:34, "Zhai, Edwin" <edwin.zhai@xxxxxxxxx> wrote:

>> passthrough.c, so the former can cleanly build without the latter. I also
>> killed pt_uninit() because I couldn't even find where pci_cleanup() was
> pci_cleanup() is in the libpci, which should be called for clean up in theory.
> But things goes well without it.

Well, you can add it back in then.

>> defined. No passthrough function should be in vl.c: I #ifdef'ed in the for
> Our plan is making this hotplug generic besides passthough device, even for
> virtual PCI device on native QEMU. So leaving do_pci_add/del in vl.c should be
> okay like do_usb_xxx.

Isn't there a generic pci source file where they might more sensibly belong?

 -- Keir

Xen-devel mailing list