This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH][HVM] pass-through PCI device hotplug support

To: "Zhai, Edwin" <edwin.zhai@xxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH][HVM] pass-through PCI device hotplug support
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Fri, 15 Feb 2008 14:36:49 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 15 Feb 2008 06:37:29 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20080215133201.GB21201@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Achv4DJ1cQktq9vTEdyWTAAX8io7RQ==
Thread-topic: [PATCH][HVM] pass-through PCI device hotplug support
User-agent: Microsoft-Entourage/
On 15/2/08 13:32, "Zhai, Edwin" <edwin.zhai@xxxxxxxxx> wrote:

> This patch is the new version against 17051 to enable HVM guest VT-d device
> hotplug.
> ** Currently only 2 virtual pci slots(6~7) are made as being capable of
> hotplug, 
> so more than 2 vtd dev can't be hotplugged, but we can easily extend it in
> future.

Now applied, but perhaps too hastily. I found it broke the
!CONFIG_PASSTHROUGH build and in fixing that I noticed that you dumped code
in a bunch of random places in qemu. Perhaps all passthrough stuff should be
gathered in one place? Alternatively at least the device model changes (in
piix4acpi.c) should be decoupled a bit from the backend logic in
passthrough.c, so the former can cleanly build without the latter. I also
killed pt_uninit() because I couldn't even find where pci_cleanup() was
defined. No passthrough function should be in vl.c: I #ifdef'ed in the for
now but the functions should probably be moved. And you did a big dump of
random crap into vl.h.

 -- Keir

Xen-devel mailing list