c/s 17056 also works for AMD-IOMMU, attached patch introduces a new
vendor independent interface for device detachment.
AMD Saxony, Dresden, Germany
Operating System Research Center
AMD Saxony Limited Liability Company & Co. KG
Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland
Registergericht Dresden: HRA 4896
AMD Saxony LLC (Sitz Wilmington, Delaware, USA)
Geschäftsführer der AMD Saxony LLC:
Dr. Hans-R. Deppe, Thomas McCoy
On Fri, 2008-02-15 at 14:36 +0000, Keir Fraser wrote:
> On 15/2/08 13:32, "Zhai, Edwin" <edwin.zhai@xxxxxxxxx> wrote:
> > This patch is the new version against 17051 to enable HVM guest VT-d device
> > hotplug.
> > ** Currently only 2 virtual pci slots(6~7) are made as being capable of
> > hotplug,
> > so more than 2 vtd dev can't be hotplugged, but we can easily extend it in
> > future.
> Now applied, but perhaps too hastily. I found it broke the
> !CONFIG_PASSTHROUGH build and in fixing that I noticed that you dumped code
> in a bunch of random places in qemu. Perhaps all passthrough stuff should be
> gathered in one place? Alternatively at least the device model changes (in
> piix4acpi.c) should be decoupled a bit from the backend logic in
> passthrough.c, so the former can cleanly build without the latter. I also
> killed pt_uninit() because I couldn't even find where pci_cleanup() was
> defined. No passthrough function should be in vl.c: I #ifdef'ed in the for
> now but the functions should probably be moved. And you did a big dump of
> random crap into vl.h.
> -- Keir
> Xen-devel mailing list
Description: Text document
Xen-devel mailing list