Re: [Xen-devel] [PATCH 2 of 2] Added a hook for clearing ptes wh

To:	"Isaku Yamahata" <yamahata@xxxxxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH 2 of 2] Added a hook for clearing ptes when a vma is freed by the kernel. Adapted from gntdev
From:	"Geoffrey Lefebvre" <geoffrey@xxxxxxxxx>
Date:	Wed, 23 May 2007 11:01:28 -0700
Cc:	Jake.Wires@xxxxxxxxxxxxx, andrew.warfield@xxxxxxxxxxxx, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date:	Wed, 23 May 2007 10:59:45 -0700
Dkim-signature:	a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=I7ysGFAGEhgoltQV8vDYfikMn19rciAnATvty49lbrcpwUvPY5KD+i6P2SoR9fwUEyqovUxL73olL4pcLyy4VjqD+oxzknei5Yvxo2YxYYtZgvEZ/+OL1sAtVPWJ3U2HGcKY6jyU1w6YoRL6eFcRXLIqw6MB9EZfyJCf2fQTTZ0=
Domainkey-signature:	a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=s8O58LPWtAaoK7koR+gkWLixxDhQb31hR8MkSjr2GB77C63yCY6gAHCL3nbClGMKoSJQ/A1T0BSZhnX1wRF7YaxyRh/gjjjVKLAkgyBonbrmyGN3XD6+ABVLmo4j3Ue89s7j2byTJ+YdabyFxMXfaRnkhjj1DHee1M3s98M71O4=
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<20070523104418.GA4949%yamahata@xxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References:	<patchbomb.1179843474@xxxxxxxxxxxxxxxxxxxxx> <236647990e986bca16f1.1179843476@xxxxxxxxxxxxxxxxxxxxx> <20070523104418.GA4949%yamahata@xxxxxxxxxxxxx>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

Hi,

Thanks for the comment. I will update the patch.

geoffrey

On 5/23/07, Isaku Yamahata <yamahata@xxxxxxxxxxxxx> wrote:

Hi.

On Tue, May 22, 2007 at 07:17:56AM -0700, Geoffrey Lefebvre wrote:
> +static pte_t blktap_clear_pte(struct vm_area_struct *vma,
> +                           unsigned long uvaddr,
> +                           pte_t *ptep, int is_fullmm)
   [ snip ]
> +     if (khandle->user != INVALID_GRANT_HANDLE) {
> +
> +             BUG_ON(xen_feature(XENFEAT_auto_translated_physmap));
> +
> +             gnttab_set_unmap_op(&unmap[count], virt_to_machine(ptep),
> +                                 GNTMAP_host_map
> +                                 | GNTMAP_application_map
> +                                 | GNTMAP_contains_pte,
> +                                 khandle->user);
> +             count++;
> +     }

'else pte_clear_full(...)' is necessary like gntdev for
auto translated physmap mode.

--
yamahata


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH 2 of 2] Added a hook for clearing ptes when a vma