This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Is patches/linux-2.6.18/xen-hotplug.patch still necessar

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] Is patches/linux-2.6.18/xen-hotplug.patch still necessary?
From: Alex Williamson <alex.williamson@xxxxxx>
Date: Wed, 09 May 2007 09:07:20 -0600
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Wed, 09 May 2007 08:06:00 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C2673151.703F%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: OSLO R&D
References: <C2673151.703F%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Wed, 2007-05-09 at 08:05 +0100, Keir Fraser wrote:
> On 8/5/07 23:26, "Alex Williamson" <alex.williamson@xxxxxx> wrote:
> >    Is the patch below, that's currently in the Xen tree, still
> > necessary?  The original commit comment indicates this is so things like
> > 'top' don't get upset during CPU hotplugs.  But should that be handled
> > by the hotplug infrastructure in the kernel (or top itself)?
> It has to be handled in top itself. With some versions at least it was the
> case that top would crash when CPUs where hot-unplugged. If you revert that
> patch, does your version of top work okay in the hot-unplug case (you have
> to run top across the unplug operation to see if it will crash or not)?

   Top still crashes without that patch, but the patch just hides the
problem.  Top also crashes during a CPU hotplug operation on bare metal.
I think this patch causes more problems than if fixes.  Thanks,


Alex Williamson                             HP Open Source & Linux Org.

Xen-devel mailing list