This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Is patches/linux-2.6.18/xen-hotplug.patch still necessary?

To: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] Is patches/linux-2.6.18/xen-hotplug.patch still necessary?
From: Alex Williamson <alex.williamson@xxxxxx>
Date: Tue, 08 May 2007 16:26:05 -0600
Delivery-date: Tue, 08 May 2007 15:24:39 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: OSLO R&D
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
   Is the patch below, that's currently in the Xen tree, still
necessary?  The original commit comment indicates this is so things like
'top' don't get upset during CPU hotplugs.  But should that be handled
by the hotplug infrastructure in the kernel (or top itself)?  IMHO, this
breaks top more than fixes it.  Now when I try to look at individual
processor statistics, I see quite a few lines of zeros (2 online CPUs,
16 possible CPUs).  AFAICT, this also breaks all of the NPROCESSORS
queries for sysconf.  Can we dump it?  Thanks,


diff -pruN ../orig-linux-2.6.18/fs/proc/proc_misc.c ./fs/proc/proc_misc.c
--- ../orig-linux-2.6.18/fs/proc/proc_misc.c    2006-09-20 04:42:06.000000000 
+++ ./fs/proc/proc_misc.c       2007-01-12 18:18:36.000000000 +0000
@@ -471,7 +471,7 @@ static int show_stat(struct seq_file *p,
                (unsigned long long)cputime64_to_clock_t(irq),
                (unsigned long long)cputime64_to_clock_t(softirq),
                (unsigned long long)cputime64_to_clock_t(steal));
-       for_each_online_cpu(i) {
+       for_each_possible_cpu(i) {
                /* Copy values here to work around gcc-2.95.3, gcc-2.96 */
                user = kstat_cpu(i).cpustat.user;

Alex Williamson                             HP Open Source & Linux Org.

Xen-devel mailing list