This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] Is patches/linux-2.6.18/xen-hotplug.patch still necessar

To: Alex Williamson <alex.williamson@xxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Is patches/linux-2.6.18/xen-hotplug.patch still necessary?
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Wed, 09 May 2007 08:05:37 +0100
Delivery-date: Wed, 09 May 2007 00:02:17 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1178663165.31282.18.camel@lappy>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AceSCHHMsDiNif37Edu9MQAWy6hiGQ==
Thread-topic: [Xen-devel] Is patches/linux-2.6.18/xen-hotplug.patch still necessary?
User-agent: Microsoft-Entourage/
On 8/5/07 23:26, "Alex Williamson" <alex.williamson@xxxxxx> wrote:

>    Is the patch below, that's currently in the Xen tree, still
> necessary?  The original commit comment indicates this is so things like
> 'top' don't get upset during CPU hotplugs.  But should that be handled
> by the hotplug infrastructure in the kernel (or top itself)?

It has to be handled in top itself. With some versions at least it was the
case that top would crash when CPUs where hot-unplugged. If you revert that
patch, does your version of top work okay in the hot-unplug case (you have
to run top across the unplug operation to see if it will crash or not)?

 -- Keir

Xen-devel mailing list