This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel][Xense-devel][PATCH][1/4] Xen Security Modules: XSM

To: "John McDermott (US Navy Employee)" <mcdermott@xxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel][Xense-devel][PATCH][1/4] Xen Security Modules: XSM
From: Mark Williamson <mark.williamson@xxxxxxxxxxxx>
Date: Tue, 8 May 2007 14:12:23 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, xense-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 08 May 2007 06:12:14 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <464070A1.7020009@xxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1178574070.6520.87.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxx> <200705080354.19579.mark.williamson@xxxxxxxxxxxx> <464070A1.7020009@xxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.6
> Does your tool have a pretty-printing capability? It seems like it would
> be more efficient to just reformat the source to comply with whatever
> standards Xen follows. Everyone could apply the tool before building
> patches or submitting code, but still use their own locally preferred
> style while developing.

It doesn't have this capability at the moment.  It's just a version of the 
Linux patchstylecheckemail.pl that I've modified to understand the different 
coding conventions in Xen.  GNU indent can quite possibly be configured to 
reformat the code as required - I'll look into finding a configuration setup 
that works for this (I'll probably start with the Linux lindent script and 
work from there - we're reasonably close to Linux conventions in many ways).

The style checker does various checks beyond indenting, though, so it'll still 
be worth running it.  I hope to get the it into mainline Xen at some point so 
that folks can just "make stylecheck" or similar before they submit patches.

Thanks for the feedback!


Dave: Just a question. What use is a unicyle with no seat?  And no pedals!
Mark: To answer a question with a question: What use is a skateboard?
Dave: Skateboards have wheels.
Mark: My wheel has a wheel!

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>