This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel][Xense-devel][PATCH][1/4] Xen Security Modules: XSM

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel][Xense-devel][PATCH][1/4] Xen Security Modules: XSM
From: Mark Williamson <mark.williamson@xxxxxxxxxxxx>
Date: Tue, 8 May 2007 03:54:19 +0100
Cc: "George S. Coker, II" <gscoker@xxxxxxxxxxxxxx>, xense-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 07 May 2007 19:54:31 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1178574070.6520.87.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1178574070.6520.87.camel@xxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.6
Hi George,

I've been working on some automated checking tools for the Xen tree and I'm 
afraid your patches came at a convenient time for you to be a test case - 
sorry :-)

> Updates in this patch set include:
>     - adaptation to new create secure interface for domain_create
>     - cleanup of xsm enable/disable framework through xsm_call macro
>     - ifdef architecture/config specific hooks

Right now I've got a load of coding style nits that you might be interested 
in.  I'm attaching the relevant output of the Xen style checking tool 
(derived from a pre-existing Linux style checker) below; I've given it a look 
through to verify that it appears sane.  It's largely based on my 
interpretation of what the Xen codebase style appears to be, so there may be 
some things you disagree with.

I realise you're still iterating on the design, but I hope this is useful for 
getting ready for the merge.  Please feel free to give feedback if you 
disagree with of the details.


Dave: Just a question. What use is a unicyle with no seat?  And no pedals!
Mark: To answer a question with a question: What use is a skateboard?
Dave: Skateboards have wheels.
Mark: My wheel has a wheel!

Attachment: xsm-050707-xen-15011-checking
Description: Text Data

Xen-devel mailing list