WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Avoid triggering the softlockup BUG when offline

To: Glauber de Oliveira Costa <gcosta@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Avoid triggering the softlockup BUG when offline for too long.
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Mon, 27 Nov 2006 10:21:54 +0000
Delivery-date: Mon, 27 Nov 2006 02:21:58 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20061124131022.GB7171@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AccSDdwbGnEGJX4BEduPjQAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] Avoid triggering the softlockup BUG when offline for too long.
User-agent: Microsoft-Entourage/11.2.5.060620


On 24/11/06 13:10, "Glauber de Oliveira Costa" <gcosta@xxxxxxxxxx> wrote:

> After being offline for a long time, the softlockup  watchdog triggers
> a BUG() on our faces. This is expected, as in fact, we spent more than
> a fixed 10*HZ amount of time without touching the watchdog.
> 
> However, by inspecting the contents of RUNSTATE_offline, we can gain
> awareness of the fact, and do better than that. This patch fixes it.
> 
> Signed-off-by: Glauber de Oliveira Costa <gcosta@xxxxxxxxxx>

Would 'stolen' not be a good enough thing to test? Presumably this is really
just dealing with xm pause/unpause (a single long offline) so this simpler
fix would work just as well?

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel