WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Avoid triggering the softlockup BUG when offline

To: Keir Fraser <keir@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Avoid triggering the softlockup BUG when offline for too long.
From: Glauber de Oliveira Costa <gcosta@xxxxxxxxxx>
Date: Wed, 29 Nov 2006 09:46:08 -0200
Cc: Glauber de Oliveira Costa <glommer@xxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 29 Nov 2006 03:46:21 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C190E4E2.4E08%keir@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <5d6222a80611270847y5e05b994sa9bce57819a3eea5@xxxxxxxxxxxxxx> <C190E4E2.4E08%keir@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.11
On Mon, Nov 27, 2006 at 06:54:26PM +0000, Keir Fraser wrote:
> > FYI, I just made a simple test checking for stolen time instead of
> > offline, and it's in fact called way too oftenly.
> 
> That doesn't make sense. Processed_stolen_time should lag at most 1 jiffy
> behind actual stolen time. So you still need to accumulate at least 10*HZ-1
> jiffies of stolen time in one go to end up touching the softlockup watchdog.
> As far as I can see, anyway. What workload did you run to test using stolen
> time?

Thanks for pointing it, Keir.

After going back to it, I found it to be a small mistake of mine. I was
calling the softlockup watchdog before accounting stolen ticks. Calling
it after it does the trick.

I'll resend the patch soon.

-- 
Glauber de Oliveira Costa
Red Hat Inc.
"Free as in Freedom"

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel