Re: [Xen-devel] netback crash with xen3.0.3

[Jacob Gorm Hansen <jacobg@xxxxxxx>]

On Fri, Nov 24, 2006 at 07:16:13PM -0000, Ian Pratt wrote:

> > I am working on a network driver for mini-os, and after creating a lot
> > of semi-broken test domains, and a lot of vifs (80 or so), I got dom0
> to
> > crash like below.
> > 
> > I have no idea how to reproduce this, just wanted to let people know
> > there is a some bug in netback somewhere.
> 
> Please could you try and look at the disassembly and figure out which
> pointer dereference is causing the problem. Are you using rx-copy or
> rx-flip?

hi,

I am using rx-copy. The bug seems to stem from the first DPRINTK in
netbk_check_gop, where gop may be used unitialized. Actually, gcc already warns
about this, and since most people will not have this printk, it is probably 
harmless in real life.

Jacob

===============

static int netbk_check_gop(int nr_frags, domid_t domid,
               struct netrx_pending_operations *npo)
{
    multicall_entry_t *mcl;
    gnttab_transfer_t *gop;
    gnttab_copy_t     *copy_op;
    int status = NETIF_RSP_OKAY;
    int i;

    for (i = 0; i <= nr_frags; i++) {
        if (npo->meta[npo->meta_cons + i].copy) {
            copy_op = npo->copy + npo->copy_cons++;
            if (copy_op->status != GNTST_okay) {
                DPRINTK("Bad status %d from copy to DOM%d.\n",
                    gop->status, domid);
                status = NETIF_RSP_ERROR;
            }
        } else {

...

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel