xen-devel

[Top] [All Lists]

[Xen-devel] [PATCH] always call SDL_Quit

from [Charles Coffing]

[Permanent Link][Original]

To:	<xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject:	[Xen-devel] [PATCH] always call SDL_Quit
From:	"Charles Coffing" <ccoffing@xxxxxxxxxx>
Date:	Thu, 12 Oct 2006 12:48:29 -0400
Delivery-date:	Thu, 12 Oct 2006 09:49:10 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

When qemu-dm is using SDL and has the mouse captured, a "xm destroy" of the VM 
will cause control of the mouse to be lost.  This happens because the qemu-dm 
is killed with SIGKILL, so atexit doesn't run, so SDL_Quit doesn't run.  Other 
things could go wrong too -- for example, if the VM was fullscreen, the video 
mode probably wouldn't be reset either.

There was a discussion a few years ago on the SDL mailing list regarding the 
ramifications of not calling SDL_Quit.  In short, you don't want to skip it:
http://www.libsdl.org/pipermail/sdl/2004-May/062400.html

The attached patch sends a SIGTERM instead of SIGKILL.  I've been using a 
variation of this patch since our SLES 10 betas, and I've never seen a case 
where SIGKILL was actually needed.

Please apply.

Signed-off-by: Charles Coffing <ccoffing@xxxxxxxxxx>

xen-lost-mouse.diff
Description: Binary data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] always call SDL_Quit, Charles Coffing <=

Previous by Date:	Re: [Xen-devel] [PATCH] [XEND] Remove hard tabs, Mark Williamson
Next by Date:	[Xen-devel] Testing status of HVM (Intel VT) on 64bit XEN unstable c/s 11736, Ed Smith
Previous by Thread:	Re: [Xen-devel] [PATCH] [XEND] Remove hard tabs, Mark Williamson
Next by Thread:	[Xen-devel] Testing status of HVM (Intel VT) on 64bit XEN unstable c/s 11736, Ed Smith
Indexes:	[Date] [Thread] [Top] [All Lists]