This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH resend] allow connecting to xenconsole from remot

To: Muli Ben-Yehuda <muli@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH resend] allow connecting to xenconsole from remote hosts
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Thu, 28 Sep 2006 09:42:29 +0100
Cc: Jimi Xenidis <jimix@xxxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Anthony Liguori <anthony@xxxxxxxxxxxxx>, Orran Y Krieger <okrieg@xxxxxxxxxx>
Delivery-date: Thu, 28 Sep 2006 01:41:36 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20060927211413.GE4542@xxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acbi2gfnRqKwIU7NEdu+mQAX8io7RQ==
Thread-topic: [PATCH resend] allow connecting to xenconsole from remote hosts
User-agent: Microsoft-Entourage/
On 27/9/06 22:14, "Muli Ben-Yehuda" <muli@xxxxxxxxxx> wrote:

>>  2. I think the buffering code is not quite there yet. What you want is to
>> make all fd's non-blocking, have small (e.g., 1kB) buffers, and then only
>> add an fd to the read-set if its buffer is not full,  and only add an fd to
>> the write-set if its buffer is not empty. The buffers can stay as ring
>> buffers, so a bunch of that code probably stays.
> Ok. I think it will end up being more code than what we do right now,
> but if you prefer it this way, fine.

We'll see. I think it'll be more readable to have the two issues addresses
in separate patches anyway.

>>  3. The networking options are confusing. What are the 'remote' and
>> 'gateway' options intended for?
> --remote = activate the networking.
> --gateway = allow connections from any host, not just localhost

Isn't --remote implied by --port? Is it useful to be able to select
networking yet not specify a port? I think --remote is a better name for
--gateway (i.e., you accept remote connections). The term 'gateway' doesn't
mean anything to me in this context.

 -- Keir

Xen-devel mailing list